Skip to content

KAFKA-6225: Adds an option to consume continuously#4082

Closed
astubbs wants to merge 2 commits into
apache:trunkfrom
astubbs:continuous-poll
Closed

KAFKA-6225: Adds an option to consume continuously#4082
astubbs wants to merge 2 commits into
apache:trunkfrom
astubbs:continuous-poll

Conversation

@astubbs

@astubbs astubbs commented Oct 17, 2017

Copy link
Copy Markdown
Contributor

No description provided.

@astubbs astubbs changed the title MINOR: Adds an option to consume continuously WIP MINOR: Adds an option to consume continuously Oct 17, 2017
@astubbs

astubbs commented Oct 18, 2017

Copy link
Copy Markdown
Contributor Author

IMO this should actually be the default behaviour but it’s an “interface” change. This or setting the timeout to max int and exposing it as configurable.

@astubbs

astubbs commented Oct 18, 2017

Copy link
Copy Markdown
Contributor Author

I think the build failed on jenkins due to this infinite loop warning from FindBugs: https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/8934/findbugsResult/ . And indeed it is an infinite loop by design.
The other option could be to make the timeout in ConsumerPerformance configurable at the cli... Atm it’s hard coded to stop consuming if their haven’t been any new messages in 1 second.

@astubbs

astubbs commented Oct 18, 2017

Copy link
Copy Markdown
Contributor Author

It was pointed out the old consumer code path was invalid due to the iterator pattern that I hadn''t noticed (as opposed to the new consumer poll pattern). It's an option to just remove it from the old consumer code path.

@astubbs astubbs changed the title WIP MINOR: Adds an option to consume continuously KAFKA-6225: Adds an option to consume continuously Nov 17, 2017
@rootex-

rootex- commented May 29, 2018

Copy link
Copy Markdown
Contributor

@themaxempire23

Copy link
Copy Markdown

Hello is this still an issue?

@github-actions

Copy link
Copy Markdown

This PR is being marked as stale since it has not had any activity in 90 days. If you
would like to keep this PR alive, please leave a comment asking for a review. If the PR has
merge conflicts, update it with the latest from the base branch.

If you are having difficulty finding a reviewer, please reach out on the [mailing list](https://kafka.apache.org/contact).

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.

@github-actions github-actions Bot added the stale Stale PRs label Oct 17, 2024
@github-actions

Copy link
Copy Markdown

This PR has been closed since it has not had any activity in 120 days. If you feel like this
was a mistake, or you would like to continue working on it, please feel free to re-open the
PR and ask for a review.

@github-actions github-actions Bot added the closed-stale PRs that were closed due to inactivity label Nov 16, 2024
@github-actions github-actions Bot closed this Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

closed-stale PRs that were closed due to inactivity stale Stale PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants